[CALCITE-7428] Support regexp function change regexp operator for Hive library by cjj2010 · Pull Request #4818 · apache/calcite

cjj2010 · 2026-03-04T03:13:15Z

jira: https://issues.apache.org/jira/browse/CALCITE-7428

mihaibudiu · 2026-03-04T17:27:27Z

There is a question in JIRA. The documentation you link to shows an infix operator REGEXP, but you are implementing support for a function.

xuzifu666 · 2026-03-05T06:28:22Z

core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java

    case TRIM:
      RelToSqlConverterUtil.unparseHiveTrim(writer, call, leftPrec, rightPrec);
      break;
+    case REGEXP:


Judging from your Jira information, you want to add a new function, right? If you add this function, the dialect won't need to be modified.

Judging from your Jira information, you want to add a new function, right? If you add this function, the dialect won't need to be modified.

Yes, REGEXP is an infix operator in Hive, but there is already a REGEXP function in Cacltie. If another REGEXP operator is added, the original SQL parsing will report an error: "Incorrect syntax near the keyword 'REGEXP'". Therefore, my idea is to convert the REGEXP function into a REGEXP operator based on the Hive dialect, I'm not sure if this is correct

Based on your Jira description, is it true that select brand_name from product where REGEXP(brand_name,'[a-zA-Z]') won't work in Hive? It needs to be converted to select brand_name from product where brand_name REGEXP '[a-zA-Z]'.

Based on your Jira description, is it true that select brand_name from product where REGEXP(brand_name,'[a-zA-Z]') won't work in Hive? It needs to be converted to select brand_name from product where brand_name REGEXP '[a-zA-Z]'.

Yes

Okay, please describe it in detail in Jira, it doesn't seem very clear.

Okay, please describe it in detail in Jira, it doesn't seem very clear.

Thank you for your suggestion. The changes have been made more accurately

Another point is that, as I understand it from Jira's perspective, there's no need to introduce a new SqlKind.

xuzifu666 · 2026-03-09T06:33:15Z

core/src/main/java/org/apache/calcite/sql/SqlKind.java

+  OTHER_DDL,
+
+  /** The {@code REGEXP} function. */
+  REGEXP;


Why make this change? If it were a dialect conversion, it could be determined using SqlOperator.

Why make this change? If it were a dialect conversion, it could be determined using SqlOperator.

Can we modify the function to
SqlBasicFunction.create(SqlKind.RLIKE, ReturnTypes.BOOLEAN_NULLABLE,
OperandTypes.STRING_STRING);
Using SQL Kind.RLIKE, it seems that there is a need for a kind in HiveSQL Dialect to perform conversion judgments, and I am not sure if I understand it correctly

I think you can refer to the suggestions in Jira.

I think you can refer to the suggestions in Jira.

I have already modified and resubmitted the code. Can you help me review the code again. Thank you

xuzifu666 · 2026-03-09T06:34:27Z

core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java

    case TRIM:
      RelToSqlConverterUtil.unparseHiveTrim(writer, call, leftPrec, rightPrec);
      break;
+    case REGEXP:


Another point is that, as I understand it from Jira's perspective, there's no need to introduce a new SqlKind.

xuzifu666

Left some comments.

xuzifu666 · 2026-03-13T02:04:03Z

core/src/main/java/org/apache/calcite/util/RelToSqlConverterUtil.java

+   */
+  public static void unparseRegexp(SqlWriter writer, SqlCall call, int leftPrec, int rightPrec) {
+    if (call.operandCount() != 2) {
+      throw new IllegalArgumentException("REGEXP operator requires exactly 2 operands");


This line of code was not covered by tests.

This line of code was not covered by tests.

I tried to execute REGEXP ("brandname"), which checks for errors during the SQL parsing validation phase and does not enter the dialect parsing phase. I think I need to remove the judgment logic in the code

xuzifu666 · 2026-03-13T02:07:57Z

core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java


  /** The "REGEXP(value, regexp)" function, equivalent to {@link #RLIKE}. */
-  @LibraryOperator(libraries = {SPARK})
+  @LibraryOperator(libraries = {SPARK, HIVE})


Since it's been added to libraries in this PR, Hive should also be added to SqlOperatorTest.

Since it's been added to libraries in this PR, Hive should also be added to SqlOperatorTest.

done

… comments

sonarqubecloud · 2026-03-13T06:51:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Terran added 2 commits March 4, 2026 11:07

Add regexp function (enabled in Hive library)

c39f9ff

Add testCase

e2c80f3

xuzifu666 reviewed Mar 5, 2026

View reviewed changes

xuzifu666 reviewed Mar 9, 2026

View reviewed changes

Del REGEXP SqlKind

a8cd4bd

cjj2010 force-pushed the CALCITE-7428 branch from 62b739f to a8cd4bd Compare March 12, 2026 12:17

Change variable name

41b5ac4

xuzifu666 reviewed Mar 13, 2026

View reviewed changes

cjj2010 changed the title ~~[CALCITE-7428] Add regexp function (enabled in Hive library)~~ [CALCITE-7428] Support regexp function change regexp operator for Hive library Mar 13, 2026

Remove redundant judgments from the unparseRegexp function and modify…

ee41884

… comments

Conversation

cjj2010 commented Mar 4, 2026

Uh oh!

mihaibudiu commented Mar 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xuzifu666 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 13, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants